Refactor out looking up clob pair into SQL function. #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes primarily involve the introduction of a new PostgreSQL function Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (6)
- indexer/services/ender/src/helpers/postgres/postgres-functions.ts (1 hunks)
- indexer/services/ender/src/scripts/dydx_get_perpetual_market_for_clob_pair.sql (1 hunks)
- indexer/services/ender/src/scripts/dydx_liquidation_fill_handler_per_order.sql (1 hunks)
- indexer/services/ender/src/scripts/dydx_order_fill_handler_per_order.sql (1 hunks)
- indexer/services/ender/src/scripts/dydx_stateful_order_handler.sql (2 hunks)
- indexer/services/ender/src/scripts/dydx_update_perpetual_position_aggregate_fields.sql (1 hunks)
Files skipped from review due to trivial changes (2)
- indexer/services/ender/src/helpers/postgres/postgres-functions.ts
- indexer/services/ender/src/scripts/dydx_stateful_order_handler.sql
Additional comments: 4
indexer/services/ender/src/scripts/dydx_get_perpetual_market_for_clob_pair.sql (1)
- 1-23: The new function
dydx_get_perpetual_market_for_clob_pairis well defined and handles exceptions for no data found and too many rows. It returns aperpetual_marketstype. Ensure that the function is being used correctly in the rest of the codebase.indexer/services/ender/src/scripts/dydx_update_perpetual_position_aggregate_fields.sql (1)
- 15-21: The change in the declaration of
perpetual_position_recordto match the row type of theperpetual_positionstable is a good practice. It ensures that the variable will have the same structure as the table, which can prevent potential issues if the table structure changes in the future.indexer/services/ender/src/scripts/dydx_liquidation_fill_handler_per_order.sql (1)
- 52-55: The retrieval of the
perpetual_market_recordhas been abstracted into thedydx_get_perpetual_market_for_clob_pairfunction. This improves code readability and maintainability. Ensure that the new function handles all edge cases and exceptions that were previously handled in this script.indexer/services/ender/src/scripts/dydx_order_fill_handler_per_order.sql (1)
- 46-49: The new function
dydx_get_perpetual_market_for_clob_pairis used here to retrieve the perpetual market data. Ensure that this function is correctly implemented and tested, as it is now a critical part of thedydx_order_fill_handler_per_orderfunction.
Comment on lines
51
to
52
| BEGIN | ||
| SELECT * INTO STRICT asset_record FROM assets WHERE "id" = usdc_asset_id; |
There was a problem hiding this comment.
The query to retrieve the asset record is not wrapped in a try-catch block. If the query fails for any reason (e.g., the asset with the given ID does not exist), it will cause the entire function to fail. Consider adding error handling here.
+ BEGIN
SELECT * INTO STRICT asset_record FROM assets WHERE "id" = usdc_asset_id;
+ EXCEPTION
+ WHEN NO_DATA_FOUND THEN
+ RAISE EXCEPTION 'Unable to find asset with id %', usdc_asset_id;
+ END;Commitable suggestion
[!IMPORTANT]
Carefully review the code before committing. Make sure it correctly replaces the highlighted code, has no missing lines and indentaion issues.
Suggested change
| BEGIN | |
| SELECT * INTO STRICT asset_record FROM assets WHERE "id" = usdc_asset_id; | |
| BEGIN | |
| SELECT * INTO STRICT asset_record FROM assets WHERE "id" = usdc_asset_id; | |
| EXCEPTION | |
| WHEN NO_DATA_FOUND THEN | |
| RAISE EXCEPTION 'Unable to find asset with id %', usdc_asset_id; | |
| END; |
vincentwschau
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Refactor out looking up clob pair into SQL function.
Test Plan
No change.
Author/Reviewer Checklist
state-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.