Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context for docker-compose builds since it is necessary for newer versions of Docker. #732

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

lcwik
Copy link
Contributor

@lcwik lcwik commented Oct 31, 2023

Changelist

Add context for docker-compose builds since it is necessary for newer versions of Docker.

Otherwise docker-compose up fails with an error saying build context is required.

Test Plan

Tested locally + existing integration tests

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

… versions of Docker.

Otherwise docker-compose up fails with an error saying build context is required.
@lcwik lcwik merged commit 5b998dc into main Nov 1, 2023
@lcwik lcwik deleted the lukedockercontext branch November 1, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants