Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-715] Bridge Daemon: Do not require eth rpc endpoint. Instead panic on startup (backport #725) #727

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 30, 2023

This is an automatic backport of pull request #725 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…artup if flag is not set (#725)

(cherry picked from commit 17e3c37)
@mergify mergify bot assigned tqin7 Oct 30, 2023
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@linear
Copy link

linear bot commented Oct 30, 2023

CORE-715 Require `--bridge-daemon-eth-rpc-endpoint` to be specified at startup

Instead of falling back to the default value, we should panic or fail
Additionally, we should consider doing some validation that the Eth RPC endpoint chain ID matches the bridge param Chain ID

Context: https://dydx-team.slack.com/archives/C05FPTMD5PT/p1698266649721799?thread_ts=1698262389.231369&cid=C05FPTMD5PT

@tqin7 tqin7 merged commit d08c8e0 into release/protocol/v1.x Oct 30, 2023
13 of 16 checks passed
@tqin7 tqin7 deleted the mergify/bp/release/protocol/v1.x/pr-725 branch October 30, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant