Code

[CORE-666] - Robust health check#715

Code

Merged

clemire merged 28 commits intomaindydxprotocol/v4-chain:mainfrom crystal/CORE-666-robust-health-checkdydxprotocol/v4-chain:crystal/CORE-666-robust-health-checkCopy head branch name to clipboardNov 6, 2023

+434-5

Commits

Commits on Oct 31, 2023

• HealthCheck interface. Pricefeed daemon implementation of interface. No tests, no healthcheck updates on task failure.

  

  Crystal Lemire

  committed
  9a9cc58

  Copy full SHA for 9a9cc58

• Checkpoint - optional refactor of subtaskrunner into client methods.

  

  Crystal Lemire

  committed
  3b00aaf

  Copy full SHA for 3b00aaf

• Back out subtaskrunner changes.

  

  Crystal Lemire

  committed
  2250685

  Copy full SHA for 2250685

• Test cases for daemon health.

  

  Crystal Lemire

  committed
  a032923

  Copy full SHA for a032923

• Channel cleanup.

  

  Crystal Lemire

  committed
  49538d9

  Copy full SHA for 49538d9

• Undo completeStartup and fix comment.

  

  Crystal Lemire

  committed
  656c256

  Copy full SHA for 656c256

• Comments.

  

  Crystal Lemire

  committed
  a1401da

  Copy full SHA for a1401da

• mega-nit: missing period.

  

  Crystal Lemire

  committed
  4f499ad

  Copy full SHA for 4f499ad

Commits on Nov 1, 2023

• remove daemon client. update internal health indicator to track error on pricefeed daemon.

  

  Crystal Lemire

  committed
  d9f7108

  Copy full SHA for d9f7108

• Pricefeed updates with new health checkable shared implementation.

  

  Crystal Lemire

  committed
  d1e2aee

  Copy full SHA for d1e2aee

Commits on Nov 2, 2023

• Updates to health-checkable - test cases, specific error messages.

  

  Crystal Lemire

  committed
  6c75e51

  Copy full SHA for 6c75e51

• Migrate pricefeed changes. Lint fix for health check tests.

  

  Crystal Lemire

  committed
  3795643

  Copy full SHA for 3795643

• Remove accidental addition to this branch.

  

  Crystal Lemire

  committed
  cebb504

  Copy full SHA for cebb504

• Remove explicit toggle to unhealthy state. This will be caught after 5 min.

  

  Crystal Lemire

  committed
  d73c727

  Copy full SHA for d73c727

• Comment cleanup.

  

  Crystal Lemire

  committed
  1e7f8a2

  Copy full SHA for 1e7f8a2

• PR feedback.

  

  Crystal Lemire

  committed
  393b53b

  Copy full SHA for 393b53b

• Performance improvement - reduce test time from 100ms to sub-ms for health-check tests.

  

  Crystal Lemire

  committed
  0c48c23

  Copy full SHA for 0c48c23

• Refactor test util method since it will be used for all daemons.

  

  Crystal Lemire

  committed
  c325aec

  Copy full SHA for c325aec

Commits on Nov 3, 2023

• Update protocol/daemons/types/health_checkable.go

  Show description for 9db3da6
  

  clemire

  and

  lcwik

  authored
  9db3da6

  Copy full SHA for 9db3da6

• Update protocol/daemons/types/health_checkable.go

  Show description for eee7e9c
  

  clemire

  and

  lcwik

  authored
  eee7e9c

  Copy full SHA for eee7e9c

• Update protocol/daemons/types/health_checkable.go

  Show description for a59c138
  

  clemire

  and

  lcwik

  authored
  a59c138

  Copy full SHA for a59c138

• Update protocol/daemons/types/health_checkable.go

  Show description for 0d8d97b
  

  clemire

  and

  lcwik

  authored
  0d8d97b

  Copy full SHA for 0d8d97b

• Update protocol/daemons/types/health_checkable.go

  Show description for 2ef12a2
  

  clemire

  and

  lcwik

  authored
  2ef12a2

  Copy full SHA for 2ef12a2

• Update protocol/daemons/types/health_checkable.go

  Show description for 34dba18
  

  clemire

  and

  lcwik

  authored
  34dba18

  Copy full SHA for 34dba18

• Remove timestamp parameter from health check reporth methods.

  

  Crystal Lemire

  committed
  4d14a5b

  Copy full SHA for 4d14a5b

• Update comment for consistency.

  

  Crystal Lemire

  committed
  7f4ae9b

  Copy full SHA for 7f4ae9b

Commits on Nov 4, 2023

• Update protocol/daemons/types/health_checkable_test.go

  Show description for a87f57f
  

  clemire

  and

  ttl33

  authored
  a87f57f

  Copy full SHA for a87f57f

• Update protocol/daemons/types/health_checkable_test.go

  Show description for 1ac3bd9
  

  clemire

  and

  ttl33

  authored
  1ac3bd9

  Copy full SHA for 1ac3bd9