Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor): Update LICENSE indicators to GNU AGPLv3 #690

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

jiajames
Copy link
Contributor

@jiajames jiajames commented Oct 24, 2023

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2023

Walkthrough

The changes primarily involve a license update across the project. The license has been changed from Business Source License 1.1 to GNU Affero General Public License v3. This change is reflected in the license files and the license badges in the README files of the project and its subdirectories.

Changes

File(s) Summary
README.md, v4-proto-js/README.md, v4-proto-py/README.md Updated the license badge from BSL 1.1 to AGPL v3. In v4-proto-js/README.md, the npm version shield was also updated to use the correct npm logo.
LICENSE, indexer/LICENSE, proto/LICENSE, protocol/LICENSE, v4-proto-js/LICENSE, v4-proto-py/LICENSE Changed the license text from Business Source License 1.1 to GNU Affero General Public License v3. The change date for the license is specified. No non-trivial alterations or additions to the code logic.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cba238d and 49563d7.
Files ignored due to filter (20)
  • indexer/package.json
  • indexer/packages/base/package.json
  • indexer/packages/compliance/package.json
  • indexer/packages/dev/package.json
  • indexer/packages/example-package/package.json
  • indexer/packages/kafka/package.json
  • indexer/packages/postgres/package.json
  • indexer/packages/redis/package.json
  • indexer/packages/v4-proto-parser/package.json
  • indexer/packages/v4-protos/package.json
  • indexer/services/auxo/package.json
  • indexer/services/bazooka/package.json
  • indexer/services/comlink/package.json
  • indexer/services/ender/package.json
  • indexer/services/roundtable/package.json
  • indexer/services/scripts/package.json
  • indexer/services/socks/package.json
  • indexer/services/vulcan/package.json
  • v4-proto-js/package-lock.json
  • v4-proto-js/package.json
Files selected for processing (3)
  • README.md (1 hunks)
  • v4-proto-js/README.md (1 hunks)
  • v4-proto-py/README.md (1 hunks)
Files skipped from review due to trivial changes (3)
  • README.md
  • v4-proto-js/README.md
  • v4-proto-py/README.md

@ttl33 ttl33 changed the title Update LICENSE indicators to GNU AGPLv3 (refactor): Update LICENSE indicators to GNU AGPLv3 Oct 24, 2023
@ttl33 ttl33 added the refactor label Oct 24, 2023
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 49563d7 and 3a84191.
Files selected for processing (6)
  • LICENSE (1 hunks)
  • indexer/LICENSE (1 hunks)
  • proto/LICENSE (1 hunks)
  • protocol/LICENSE (1 hunks)
  • v4-proto-js/LICENSE (1 hunks)
  • v4-proto-py/LICENSE (1 hunks)
Files skipped from review due to trivial changes (6)
  • LICENSE
  • indexer/LICENSE
  • proto/LICENSE
  • protocol/LICENSE
  • v4-proto-js/LICENSE
  • v4-proto-py/LICENSE

@@ -1,45 +1,3 @@
Subject to your compliance with applicable law, you are granted the right to use the Licensed Work (defined below) under the terms of the below licenses; provided, however, that if you violate any such applicable law in your use of the Licensed Work, all of your rights and licenses to use (including any rights to reproduce, distribute, install or modify) the Licensed Work will automatically and immediately terminate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to confirm, do we want to remove this entire section?

I see that we have things like: Change License: GNU Affero GPL License v3 below so I am wondering

Copy link
Contributor Author

@jiajames jiajames Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed - removing the BSL license portion is a clarifying change since the GNU AGPLv3 license is already in effect

@jiajames jiajames merged commit 6dd7647 into main Oct 24, 2023
@jiajames jiajames deleted the jj/license-gnu branch October 24, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants