(refactor): Update READMEs and comments to use dYdX Chain
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes primarily involve renaming and rebranding the project from "V4 Chain" to "dYdX Chain". This includes updates to package names, comments, documentation, and workflow configurations. The logic and functionality of the code remain unchanged. Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (11)
- .github/workflows/protocol-lint.yml (2 hunks)
- README.md (2 hunks)
- indexer/packages/postgres/README.md (1 hunks)
- indexer/packages/v4-protos/README.md (1 hunks)
- proto/README.md (1 hunks)
- proto/dydxprotocol/indexer/protocol/v1/clob.proto (1 hunks)
- proto/dydxprotocol/indexer/protocol/v1/subaccount.proto (1 hunks)
- protocol/.gitleaks.toml (1 hunks)
- protocol/README.md (6 hunks)
- v4-proto-js/README.md (1 hunks)
- v4-proto-py/README.md (1 hunks)
Files skipped from review due to trivial changes (11)
- .github/workflows/protocol-lint.yml
- README.md
- indexer/packages/postgres/README.md
- indexer/packages/v4-protos/README.md
- proto/README.md
- proto/dydxprotocol/indexer/protocol/v1/clob.proto
- proto/dydxprotocol/indexer/protocol/v1/subaccount.proto
- protocol/.gitleaks.toml
- protocol/README.md
- v4-proto-js/README.md
- v4-proto-py/README.md
ttl33
commented
Oct 24, 2023
| @@ -178,23 +178,6 @@ dasel put string -f "$CONFIG_FOLDER"/config.toml '.consensus.timeout_propose' '6 | |||
| dasel put string -f "$CONFIG_FOLDER"/config.toml '.consensus.timeout_commit' '60s' | |||
| ``` | |||
|
|
|||
| ## Bootstrapping a new module | |||
There was a problem hiding this comment.
we no longer use ignite
| ### Pricefeed Daemon | ||
|
|
||
| The Pricefeed Daemon is responsible for ingesting prices from 3rd party exchanges like Binance and sending these prices to the application where they are then used by the Prices module. The Pricefeed daemon is started by default when the application starts. | ||
|
|
||
| The path to the configuration file used for querying exchanges is dictated by the flag `pricefeed-exchange-config-file`. The default configuration file is located within `v4` at the path `daemons/configs/default_pricefeed_exchange_config.go`. The file utilizes a template that is populated from `daemons/pricefeed/client/constants/static_exchange_startup_config.go`. The first exchange within the default configuration file additionally has inline comments explaining what each field is for. |
There was a problem hiding this comment.
we got rid of this as part of this PR
ttl33
changed the title
dYdX ChaindYdX Chain
ttl33
changed the title
dYdX ChaindYdX Chain
jiajames
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (6)
- proto/dydxprotocol/indexer/events/events.proto (12 hunks)
- proto/dydxprotocol/indexer/indexer_manager/event.proto (1 hunks)
- proto/dydxprotocol/indexer/off_chain_updates/off_chain_updates.proto (2 hunks)
- proto/dydxprotocol/indexer/protocol/v1/clob.proto (1 hunks)
- proto/dydxprotocol/indexer/protocol/v1/subaccount.proto (1 hunks)
- proto/dydxprotocol/indexer/redis/redis_order.proto (1 hunks)
Files skipped from review due to trivial changes (6)
- proto/dydxprotocol/indexer/events/events.proto
- proto/dydxprotocol/indexer/indexer_manager/event.proto
- proto/dydxprotocol/indexer/off_chain_updates/off_chain_updates.proto
- proto/dydxprotocol/indexer/protocol/v1/clob.proto
- proto/dydxprotocol/indexer/protocol/v1/subaccount.proto
- proto/dydxprotocol/indexer/redis/redis_order.proto
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- proto/dydxprotocol/indexer/protocol/v1/clob.proto (1 hunks)
- proto/dydxprotocol/indexer/protocol/v1/subaccount.proto (1 hunks)
Files skipped from review due to trivial changes (2)
- proto/dydxprotocol/indexer/protocol/v1/clob.proto
- proto/dydxprotocol/indexer/protocol/v1/subaccount.proto
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- protocol/indexer/events/events.pb.go
- protocol/indexer/indexer_manager/event.pb.go
- protocol/indexer/off_chain_updates/off_chain_updates.pb.go
Files selected for processing (4)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (23 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/indexer_manager/event.ts (2 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/off_chain_updates/off_chain_updates.ts (4 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/redis/redis_order.ts (2 hunks)
Files skipped from review due to trivial changes (4)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/indexer_manager/event.ts
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/off_chain_updates/off_chain_updates.ts
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/redis/redis_order.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
dYdX Chaininstead ofv4Test Plan
N/A
Author/Reviewer Checklist
state-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.