Fix typo for fetching orders for parent subaccount. #1493

vincentwschau · 2024-05-10T20:13:12Z

Changelist

Fix typo in the URL used to fetch orders for parent subaccount.

Test Plan

Tested URLs, updated unit test (just regex though).

Author/Reviewer Checklist

If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

Refactor
- Improved URL patterns in subscription services to include additional query parameters for better data filtering in accounts.

coderabbitai · 2024-05-10T20:13:17Z

Walkthrough

The recent updates involve enhancing the specificity of URL patterns in test configurations by adding additional query parameters for improved account management. Furthermore, adjustments were made in the Subscriptions class to refine the URL parameter in an API request, ensuring accurate account details are utilized.

Changes

File Path	Change Summary
`indexer/services/socks/__tests__/lib/subscriptions.test.ts`	Updated URL patterns in `subscriptions.test.ts` to include `subaccountNumber` and `parentSubaccountNumber` in `Channel.V4_ACCOUNTS` and `Channel.V4_PARENT_ACCOUNTS`.
`indexer/services/socks/src/lib/subscription.ts`	Modified the `url` parameter in an `axiosRequest` to use `parentSubaccountNumber` instead of `subaccountNumber`.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2494557 and 746f568.

Files selected for processing (2)

indexer/services/socks/tests/lib/subscriptions.test.ts (1 hunks)
indexer/services/socks/src/lib/subscription.ts (1 hunks)

Additional Context Used

Path-based Instructions (2)

indexer/services/socks/__tests__/lib/subscriptions.test.ts (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

indexer/services/socks/src/lib/subscription.ts (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

Additional comments not posted (3)

indexer/services/socks/__tests__/lib/subscriptions.test.ts (2)

54-54: Corrected typo in URL pattern for Channel.V4_ACCOUNTS.

62-62: Updated URL pattern for Channel.V4_PARENT_ACCOUNTS to include parentSubaccountNumber.

indexer/services/socks/src/lib/subscription.ts (1)

605-605: Updated URL to correctly use parentSubaccountNumber for parent subaccount operations.

chenyaoy · 2024-05-10T20:28:16Z

indexer/services/socks/__tests__/lib/subscriptions.test.ts

@@ -51,15 +51,15 @@ describe('Subscriptions', () => {
  const initialResponseUrlPatterns: Record<Channel, string[] | undefined> = {
    [Channel.V4_ACCOUNTS]: [
      '/v4/addresses/.+/subaccountNumber/.+',
-      '/v4/orders?.+OPEN,UNTRIGGERED,BEST_EFFORT_OPENED',
+      '/v4/orders?.+subaccountNubmer.+OPEN,UNTRIGGERED,BEST_EFFORT_OPENED',


typo: Nubmer

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 746f568 and bc12f96.

Files selected for processing (1)

indexer/services/socks/tests/lib/subscriptions.test.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

indexer/services/socks/tests/lib/subscriptions.test.ts

vincentwschau · 2024-05-10T21:15:46Z

@Mergifyio backport release/indexer/v5.x

mergify · 2024-05-10T21:15:59Z

backport release/indexer/v5.x

✅ Backports have been created

#1494 Fix typo for fetching orders for parent subaccount. (backport #1493) has been created for branch release/indexer/v5.x

(cherry picked from commit 0103502)

(cherry picked from commit 0103502) Co-authored-by: vincentwschau <[email protected]>

Fix typo for fetching orders for parent subaccount.

746f568

vincentwschau marked this pull request as ready for review May 10, 2024 20:13

github-actions bot added the indexer label May 10, 2024

shrenujb approved these changes May 10, 2024

View reviewed changes

coderabbitai bot reviewed May 10, 2024

View reviewed changes

chenyaoy reviewed May 10, 2024

View reviewed changes

Fix test.

bc12f96

coderabbitai bot reviewed May 10, 2024

View reviewed changes

vincentwschau merged commit 0103502 into main May 10, 2024
11 checks passed

vincentwschau deleted the vincentc/fix-typo-socks branch May 10, 2024 21:15

mergify bot pushed a commit that referenced this pull request May 10, 2024

Fix typo for fetching orders for parent subaccount. (#1493)

f011c48

(cherry picked from commit 0103502)

mergify bot mentioned this pull request May 10, 2024

Fix typo for fetching orders for parent subaccount. (backport #1493) #1494

Merged

6 tasks

vincentwschau added a commit that referenced this pull request May 10, 2024

Fix typo for fetching orders for parent subaccount. (#1493) (#1494)

d13fae2

(cherry picked from commit 0103502) Co-authored-by: vincentwschau <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typo for fetching orders for parent subaccount. #1493

Fix typo for fetching orders for parent subaccount. #1493

vincentwschau commented May 10, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 10, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

chenyaoy May 10, 2024

coderabbitai bot left a comment

vincentwschau commented May 10, 2024

mergify bot commented May 10, 2024 •

edited

Loading

Fix typo for fetching orders for parent subaccount. #1493

Fix typo for fetching orders for parent subaccount. #1493

Conversation

vincentwschau commented May 10, 2024 • edited by coderabbitai bot Loading

Changelist

Test Plan

Author/Reviewer Checklist

Summary by CodeRabbit

coderabbitai bot commented May 10, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

chenyaoy May 10, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

vincentwschau commented May 10, 2024

mergify bot commented May 10, 2024 • edited Loading

✅ Backports have been created

vincentwschau commented May 10, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 10, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

mergify bot commented May 10, 2024 •

edited

Loading