Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRA-109] Add parent subaccount websocket (backport #1463) #1486

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Changelist

Update socks to be able to forward messages from a single topic to multiple websocket channels.
Add V4 parent subaccounts channel and forward messages from subaccounts topic to the parent websocket channel.
Add subaccount number as a top-level value in the websocket messages forwarded to clients.

Misc:

  • fixed some flakiness / issues with the message fowarding unit tests

TODO: Filtering out transfer messages from parent to a child / child to a child is not implemented.

Test Plan

Unit tests.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

This is an automatic backport of pull request #1463 done by [Mergify](https://mergify.com).

(cherry picked from commit 355d9e9)

# Conflicts:
#	indexer/services/socks/src/lib/message-forwarder.ts
Copy link
Contributor Author

mergify bot commented May 9, 2024

Cherry-pick of 355d9e9 has failed:

On branch mergify/bp/release/indexer/v5.x/pr-1463
Your branch is up to date with 'origin/release/indexer/v5.x'.

You are currently cherry-picking commit 355d9e9b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   indexer/packages/postgres/__tests__/lib/parent-subaccount-helpers.ts
	modified:   indexer/packages/postgres/src/index.ts
	new file:   indexer/packages/postgres/src/lib/parent-subaccount-helpers.ts
	modified:   indexer/services/comlink/__tests__/lib/helpers.test.ts
	modified:   indexer/services/comlink/src/lib/helpers.ts
	modified:   indexer/services/comlink/src/request-helpers/request-transformer.ts
	modified:   indexer/services/socks/__tests__/constants.ts
	modified:   indexer/services/socks/__tests__/helpers/from-kafka-helpers.test.ts
	modified:   indexer/services/socks/__tests__/lib/message-forwarder.test.ts
	modified:   indexer/services/socks/__tests__/lib/subscriptions.test.ts
	modified:   indexer/services/socks/package.json
	modified:   indexer/services/socks/src/helpers/from-kafka-helpers.ts
	modified:   indexer/services/socks/src/helpers/message.ts
	modified:   indexer/services/socks/src/lib/constants.ts
	modified:   indexer/services/socks/src/lib/subscription.ts
	modified:   indexer/services/socks/src/types.ts

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   indexer/services/socks/src/lib/message-forwarder.ts

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

linear bot commented May 9, 2024

@vincentwschau vincentwschau merged commit b3464a8 into release/indexer/v5.x May 9, 2024
11 checks passed
@vincentwschau vincentwschau deleted the mergify/bp/release/indexer/v5.x/pr-1463 branch May 9, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant