[OTE-308] Update upsert querybuilder and compliance table upsert function #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affanv14
changed the title
vincentwschau
approved these changes
May 8, 2024
| @@ -26,11 +28,16 @@ export default class UpsertQueryBuilder<M extends Model, R = M[]> extends QueryB | |||
| const colBindings = cols.map(() => '??').join(', '); | |||
| const valBindings = cols.map(() => '?').join(', '); | |||
| const setBindings = cols.map(() => '?? = ?').join(', '); | |||
| const idConditionBindings = idColumns.map(() => '?? = ?').join(' AND '); | |||
There was a problem hiding this comment.
what does ?? = ? do in this case?
There was a problem hiding this comment.
Positional bindings, see here
| @@ -40,15 +47,14 @@ export default class UpsertQueryBuilder<M extends Model, R = M[]> extends QueryB | |||
| `(${colBindings}) VALUES (${valBindings})`, | |||
| 'ON CONFLICT (??) DO', | |||
| `UPDATE SET ${setBindings}`, | |||
| 'WHERE ?? = ?', | |||
| `WHERE ${idConditionBindings}`, | |||
There was a problem hiding this comment.
iiuc if there are two idColumns like in the case of compliance data, this would be WHERE ?? = ? AND ?? = ? right?
|
https://github.com/Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
Merged
6 tasks
affanv14
added a commit
that referenced
this pull request
May 8, 2024
…tion (#1477) (#1478) * Update upsert querybuilder and compliance data upsert function * lint (cherry picked from commit a699c24) Co-authored-by: Mohammed Affan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Test Plan
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.