Orderbook Fills protos #1446
Orderbook Fills protos #1446
Conversation
WalkthroughThe recent updates focus on enhancing the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (3)
Files skipped from review as they are similar to previous changes (1)
Additional Context UsedPath-based Instructions (2)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
protocol/streaming/grpc/grpc_streaming_manager.go (2)
Line range hint
50-62: Ensure proper error handling in theSubscribemethod. Currently, it returns a generic error without specific handling or logging. Consider adding detailed error messages and logging for better debuggability.- return clobtypes.ErrInvalidGrpcStreamingRequest + return fmt.Errorf("invalid request: %w", clobtypes.ErrInvalidGrpcStreamingRequest)
Line range hint
150-160: Consider optimizing theGetUninitializedClobPairIdsmethod by caching the results or reducing the frequency of lock acquisitions, as this could potentially be a performance bottleneck in high-throughput scenarios.
| streamUpdates := clobtypes.StreamUpdate{ | ||
| UpdateMessage: &clobtypes.StreamUpdate_OrderbookUpdate{ | ||
| OrderbookUpdate: &clobtypes.StreamOrderbookUpdate{ | ||
| Updates: updatesToSend, | ||
| Snapshot: snapshot, | ||
| }, | ||
| }, | ||
| } | ||
| if err := subscription.srv.Send( | ||
| &clobtypes.StreamOrderbookUpdatesResponse{ | ||
| Updates: updatesToSend, | ||
| Snapshot: snapshot, | ||
| Updates: []clobtypes.StreamUpdate{streamUpdates}, |
There was a problem hiding this comment.
The implementation of sending updates in the SendOrderbookUpdates method appears correct. However, consider adding more robust error handling and logging to improve system resilience and maintainability.
- panic(err)
+ log.Errorf("Failed to unmarshal offchain updates: %v", err)
+ return errCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| streamUpdates := clobtypes.StreamUpdate{ | |
| UpdateMessage: &clobtypes.StreamUpdate_OrderbookUpdate{ | |
| OrderbookUpdate: &clobtypes.StreamOrderbookUpdate{ | |
| Updates: updatesToSend, | |
| Snapshot: snapshot, | |
| }, | |
| }, | |
| } | |
| if err := subscription.srv.Send( | |
| &clobtypes.StreamOrderbookUpdatesResponse{ | |
| Updates: updatesToSend, | |
| Snapshot: snapshot, | |
| Updates: []clobtypes.StreamUpdate{streamUpdates}, | |
| streamUpdates := clobtypes.StreamUpdate{ | |
| UpdateMessage: &clobtypes.StreamUpdate_OrderbookUpdate{ | |
| OrderbookUpdate: &clobtypes.StreamOrderbookUpdate{ | |
| Updates: updatesToSend, | |
| Snapshot: snapshot, | |
| }, | |
| }, | |
| } | |
| if err := subscription.srv.Send( | |
| &clobtypes.StreamOrderbookUpdatesResponse{ | |
| Updates: []clobtypes.StreamUpdate{streamUpdates}, | |
| log.Errorf("Failed to unmarshal offchain updates: %v", err) | |
| return err |
* new protos * fix prev use case * proto lint
|
@Mergifyio backport release/protocol/v4.1.x |
✅ Backports have been created
|
* new protos * fix prev use case * proto lint (cherry picked from commit 7e87c2e) # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/clob/query.rpc.Query.ts # protocol/x/clob/types/query.pb.go
Co-authored-by: Jonathan Fung <[email protected]> Co-authored-by: Jonathan Fung <[email protected]>
|
@Mergifyio backport release/protocol/v5.x |
❌ No backport have been created
GitHub error: |
✅ Backports have been created
|
* new protos * fix prev use case * proto lint (cherry picked from commit 7e87c2e) # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/clob/query.rpc.Query.ts # protocol/x/clob/types/query.pb.go
Summary by CodeRabbit
streamOrderbookUpdatesmethod to clarify the types of updates streamed.StreamOrderbookUpdatesResponseto use the newStreamUpdatetype for more detailed orderbook updates.