Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] testing flaky tests #1260

Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] testing flaky tests #1260

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0736cb
testing flaky tests
Christopher-Li Mar 27, 2024
13e6a7b
update
Christopher-Li Mar 27, 2024
acfad46
nit
Christopher-Li Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol/daemons/slinky/client/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func TestClient(t *testing.T) {
go func() {
ls, err := net.Listen("tcp", appFlags.GrpcAddress)
require.NoError(t, err)
err = grpcServer.Serve(ls)
// err = grpcServer.Serve(ls)
require.NoError(t, err)
}()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [33-33]

The gRPC server is created without specifying credentials, which could lead to insecure communication. To secure the gRPC server, consider adding SSL/TLS credentials. Here's an example of how to add credentials to the server:

+ import "google.golang.org/grpc/credentials"

  grpcServer := grpc.NewServer(
+   grpc.Creds(credentials.NewServerTLSFromFile("cert.pem", "cert.key")),
  )

Ensure you have the cert.pem and cert.key files available in your test environment. This change enhances the security of your gRPC communication during testing.

Expand Down
Loading