start from a random subaccount

dydxprotocol · Dec 22, 2023 · f500089 · f500089
1 parent 512950d
commit f500089
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/protocol/x/clob/keeper/deleveraging.go b/protocol/x/clob/keeper/deleveraging.go
@@ -240,15 +240,17 @@ func (k Keeper) OffsetSubaccountPerpetualPosition(
 		!isDeleveragingLong,
 	)
 
-	for _, subaccountId := range subaccountsWithOpenPositions {
-		// Iterate at most `MaxDeleveragingSubaccountsToIterate` subaccounts.
-		if numSubaccountsIterated >= k.Flags.MaxDeleveragingSubaccountsToIterate {
-			break
-		}
+	// Start from a random subaccount.
+	pseudoRand := k.GetPseudoRand(ctx)
+	numSubaccounts := len(subaccountsWithOpenPositions)
+	indexOffset := pseudoRand.Intn(numSubaccounts)
 
-		if deltaQuantumsRemaining.Sign() == 0 {
-			break
-		}
+	// Iterate at most `MaxDeleveragingSubaccountsToIterate` subaccounts.
+	numSubaccountsToIterate := lib.Min(numSubaccounts, int(k.Flags.MaxDeleveragingSubaccountsToIterate))
+
+	for i := 0; i < numSubaccountsToIterate && deltaQuantumsRemaining.Sign() != 0; i++ {
+		index := (i + indexOffset) % numSubaccounts
+		subaccountId := subaccountsWithOpenPositions[index]
 
 		numSubaccountsIterated++
 		offsettingSubaccount := k.subaccountsKeeper.GetSubaccount(ctx, subaccountId)