Skip to content

Commit

Permalink
fix more linting and some tests
Browse files Browse the repository at this point in the history
Signed-off-by: Shrenuj Bansal <[email protected]>
  • Loading branch information
shrenujb committed Jun 6, 2024
1 parent 8396aa4 commit d00953c
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 11 deletions.
3 changes: 2 additions & 1 deletion proto/dydxprotocol/listing/genesis.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ option go_package = "github.com/dydxprotocol/v4-chain/protocol/x/listing/types";

// GenesisState defines `x/listing`'s genesis state.
message GenesisState {
// permissionless_listing_enabled defines whether permissionless listing is enabled.
// permissionless_listing_enabled defines whether permissionless listing is
// enabled.
bool permissionless_listing_enabled = 1;
}
7 changes: 3 additions & 4 deletions proto/dydxprotocol/listing/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@ option go_package = "github.com/dydxprotocol/v4-chain/protocol/x/listing/types";
// Query defines the gRPC querier service.
service Query {
// Queries if permissionless listings are enabled
rpc PermissionlessMarketListingStatus(QueryPermissionlessMarketListingStatus) returns (QueryPermissionlessMarketListingStatusResponse);
rpc PermissionlessMarketListingStatus(QueryPermissionlessMarketListingStatus)
returns (QueryPermissionlessMarketListingStatusResponse);
}

// Queries if permissionless listings are enabled
message QueryPermissionlessMarketListingStatus {}

// Response type indicating if permissionless listings are enabled
message QueryPermissionlessMarketListingStatusResponse {
bool enabled = 1;
}
message QueryPermissionlessMarketListingStatusResponse { bool enabled = 1; }
12 changes: 8 additions & 4 deletions proto/dydxprotocol/listing/tx.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ option go_package = "github.com/dydxprotocol/v4-chain/protocol/x/listing/types";

// Msg defines the Msg service.
service Msg {
// EnablePermissionlessMarketListing enables/disables permissionless market listing
rpc EnablePermissionlessMarketListing(MsgEnablePermissionlessMarketListing) returns (MsgEnablePermissionlessMarketListingResponse);
// EnablePermissionlessMarketListing enables/disables permissionless market
// listing
rpc EnablePermissionlessMarketListing(MsgEnablePermissionlessMarketListing)
returns (MsgEnablePermissionlessMarketListingResponse);
}

// MsgEnablePermissionlessMarketListing is used to enable/disable permissionless // market listing
// MsgEnablePermissionlessMarketListing is used to enable/disable permissionless
// market listing
message MsgEnablePermissionlessMarketListing {
// The address that controls the module (the gov module account).
option (cosmos.msg.v1.signer) = "authority";
Expand All @@ -23,5 +26,6 @@ message MsgEnablePermissionlessMarketListing {
bool enable_permissionless_market_listing = 2;
}

// MsgEnablePermissionlessMarketListingResponse defines the MsgEnablePermissionlessMarketListing response
// MsgEnablePermissionlessMarketListingResponse defines the
// MsgEnablePermissionlessMarketListing response
message MsgEnablePermissionlessMarketListingResponse {}
4 changes: 4 additions & 0 deletions protocol/lib/ante/internal_msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
delaymsg "github.com/dydxprotocol/v4-chain/protocol/x/delaymsg/types"
feetiers "github.com/dydxprotocol/v4-chain/protocol/x/feetiers/types"
govplus "github.com/dydxprotocol/v4-chain/protocol/x/govplus/types"
listing "github.com/dydxprotocol/v4-chain/protocol/x/listing/types"
perpetuals "github.com/dydxprotocol/v4-chain/protocol/x/perpetuals/types"
prices "github.com/dydxprotocol/v4-chain/protocol/x/prices/types"
ratelimit "github.com/dydxprotocol/v4-chain/protocol/x/ratelimit/types"
Expand Down Expand Up @@ -93,6 +94,9 @@ func IsInternalMsg(msg sdk.Msg) bool {
// govplus
*govplus.MsgSlashValidator,

// listing
*listing.MsgEnablePermissionlessMarketListing,

// perpetuals
*perpetuals.MsgCreatePerpetual,
*perpetuals.MsgSetLiquidityTier,
Expand Down
1 change: 0 additions & 1 deletion protocol/x/listing/keeper/grpc_query_pml_enabled_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ func (k Keeper) PermissionlessMarketListingStatus(
ctx context.Context,
req *types.QueryPermissionlessMarketListingStatus,
) (*types.QueryPermissionlessMarketListingStatusResponse, error) {

enabled, err := k.IsPermissionlessListingEnabled(sdk.UnwrapSDKContext(ctx))
return &types.QueryPermissionlessMarketListingStatusResponse{
Enabled: enabled,
Expand Down
1 change: 0 additions & 1 deletion protocol/x/listing/keeper/msg_server_enable_pml_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
)

func TestMsgEnablePermissionlessMarketListing(t *testing.T) {

tests := map[string]struct {
// Msg.
msg *types.MsgEnablePermissionlessMarketListing
Expand Down

0 comments on commit d00953c

Please sign in to comment.