Fix withdrawal gating double usage of metrics name for two different …

…types of counters. (#972)
dydxprotocol · Jan 17, 2024 · 0ce663d · 0ce663d
1 parent 76068c9
commit 0ce663d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/protocol/lib/metrics/metric_keys.go b/protocol/lib/metrics/metric_keys.go
@@ -21,6 +21,7 @@ const (
 	LiquidationsLiquidationMatchNegativeTNC            = "liquidations_liquidation_match_negative_tnc"
 	ClobMevErrorCount                                  = "clob_mev_error_count"
 	SubaccountsNegativeTncSubaccountSeen               = "negative_tnc_subaccount_seen"
+	GateWithdrawalsIfNegativeTncSubaccountSeen         = "gate_withdrawals_if_negative_tnc_subaccount_seen"
 
 	// Gauges
 	InsuranceFundBalance             = "insurance_fund_balance"
@@ -41,14 +42,14 @@ const (
 	LiquidationsPlacePerpetualLiquidationQuoteQuantumsDistribution = "liquidations_place_perpetual_liquidation_quote_quantums_distribution"
 
 	// Measure Since
-	ClobOffsettingSubaccountPerpetualPosition  = "clob_offsetting_subaccount_perpetual_position"
-	DaemonGetPreviousBlockInfoLatency          = "daemon_get_previous_block_info_latency"
-	DaemonGetAllMarketPricesLatency            = "daemon_get_all_market_prices_latency"
-	DaemonGetMarketPricesPaginatedLatency      = "daemon_get_market_prices_paginated_latency"
-	DaemonGetAllLiquidityTiersLatency          = "daemon_get_all_liquidity_tiers_latency"
-	DaemonGetLiquidityTiersPaginatedLatency    = "daemon_get_liquidity_tiers_paginated_latency"
-	DaemonGetAllPerpetualsLatency              = "daemon_get_all_perpetuals_latency"
-	DaemonGetPerpetualsPaginatedLatency        = "daemon_get_perpetuals_paginated_latency"
-	MevLatency                                 = "mev_latency"
-	GateWithdrawalsIfNegativeTncSubaccountSeen = "gate_withdrawals_if_negative_tnc_subaccount_seen"
+	ClobOffsettingSubaccountPerpetualPosition         = "clob_offsetting_subaccount_perpetual_position"
+	DaemonGetPreviousBlockInfoLatency                 = "daemon_get_previous_block_info_latency"
+	DaemonGetAllMarketPricesLatency                   = "daemon_get_all_market_prices_latency"
+	DaemonGetMarketPricesPaginatedLatency             = "daemon_get_market_prices_paginated_latency"
+	DaemonGetAllLiquidityTiersLatency                 = "daemon_get_all_liquidity_tiers_latency"
+	DaemonGetLiquidityTiersPaginatedLatency           = "daemon_get_liquidity_tiers_paginated_latency"
+	DaemonGetAllPerpetualsLatency                     = "daemon_get_all_perpetuals_latency"
+	DaemonGetPerpetualsPaginatedLatency               = "daemon_get_perpetuals_paginated_latency"
+	MevLatency                                        = "mev_latency"
+	GateWithdrawalsIfNegativeTncSubaccountSeenLatency = "gate_withdrawals_if_negative_tnc_subaccount_seen_latency"
 )
diff --git a/protocol/x/clob/keeper/deleveraging.go b/protocol/x/clob/keeper/deleveraging.go
@@ -195,7 +195,7 @@ func (k Keeper) GateWithdrawalsIfNegativeTncSubaccountSeen(
 ) (err error) {
 	defer metrics.ModuleMeasureSince(
 		types.ModuleName,
-		metrics.GateWithdrawalsIfNegativeTncSubaccountSeen,
+		metrics.GateWithdrawalsIfNegativeTncSubaccountSeenLatency,
 		time.Now(),
 	)
 	metrics.IncrCounter(