Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display usd value for withdraw flow [OTE-783] #645

Merged
merged 4 commits into from
Sep 12, 2024
Merged

display usd value for withdraw flow [OTE-783] #645

merged 4 commits into from
Sep 12, 2024

Conversation

yogurtandjam
Copy link
Contributor

@yogurtandjam yogurtandjam commented Sep 12, 2024 •
edited
Loading

adds toAmountUSD to the summary state.

NOTE: we already have toAmountUSDC and usdcSize which is a bit confusing. here's an explanation of it all.

  • toAmountUSDC and usdcSize are pretty much the same thing, except that usdcSize defaults to the toAmount and is only populated on deposits. I'm not clear as to what benefit usdcSize provides.
  • this PR creates a toAmountUSD state property because skip doesn't provide a toAmountUSDC value
    • we could just present the USD value as the USDC value but there's a ~.1% difference between USDC and USD and it feels more honest to not claim we're providing USDC values.

@linear Linear
Copy link

linear bot commented Sep 12, 2024

OTE-783 display usd value for withdrawal flow

@yogurtandjam yogurtandjam marked this pull request as ready for review September 12, 2024 14:26
@yogurtandjam yogurtandjam merged commit 28240c4 into main Sep 12, 2024
3 checks passed
@yogurtandjam yogurtandjam deleted the jerms/OTE-783_display-usd-value-for-withdraw-flow branch September 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogurtandjam @ruixhuang