TRCL-3636 Static Typing: Adjust Isolated Margin Input #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/state/internalstate/InternalState.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine+Trades.kt
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/MarketProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/MarketsProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/MarketsSummaryProcessor.kt # src/commonTest/kotlin/exchange.dydx.abacus/processor/markets/MarketProcessorTests.kt # src/commonTest/kotlin/exchange.dydx.abacus/processor/markets/MarketsProcessorTests.kt # src/commonTest/kotlin/exchange.dydx.abacus/tests/mock/processor/markets/MarketProcessorMock.kt
… into feature/markets_4
This reverts commit d52adce.
…to feature/calc_1
# Conflicts: # build.gradle.kts # v4_abacus.podspec
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine+ClosePositionInput.kt
# Conflicts: # build.gradle.kts # src/commonMain/kotlin/exchange.dydx.abacus/processor/input/ClosePositionInputProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/internalstate/InternalState.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine.kt # v4_abacus.podspec
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine+AdjustIsolatedMarginInput.kt
moo-onthelawn
previously approved these changes
Aug 26, 2024
| market = data.market, | ||
| type = data.type ?: IsolatedMarginAdjustmentType.Add, | ||
| amount = parser.asString(data.amount), | ||
| amountPercent = parser.asString(data.amountPercent), |
There was a problem hiding this comment.
maybe a dumb question but why do we still need parser here and the line below?
There was a problem hiding this comment.
Those fields are defined as string type in AdjustIsolatedMarginInput, which is frontend-facing. It would be a breaking change if we change the data type.
| positionLeverage = position?.calculated?.get(CalculationPeriod.current)?.leverage, | ||
| positionLeverageUpdated = position?.calculated?.get(CalculationPeriod.post)?.leverage, | ||
| liquidationPrice = position?.calculated?.get(CalculationPeriod.current)?.liquidationPrice, | ||
| liquidationPriceUpdated = position?.calculated?.get(CalculationPeriod.post)?.liquidationPrice, |
There was a problem hiding this comment.
super nit, I wonder if this would be easier to read if we had postPosition and currentPosition variables
There was a problem hiding this comment.
Can update in the future.... and then there are two calculated fields for subaccount and position, so it gets pretty confusing.
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/processor/input/ClosePositionInputProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/internalstate/InternalState.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine.kt
moo-onthelawn
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Adjust Isolated Margin Input related classes
Adding fixing from PR.
Tested on Android and guarded by feature flag.