feat(blocktime): Relay next_block_delay from application to comet
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teddyding your pull request is missing a changelog! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
baseapp/abci.go
Outdated
Comment on lines
871
to
876
| } | ||
|
|
||
| events = append(events, endBlock.Events...) | ||
|
|
||
| cp := app.GetConsensusParams(app.finalizeBlockState.Context()) | ||
|
|
||
| return &abci.ResponseFinalizeBlock{ |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/abci.go:733)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:894)
baseapp/abci.go
Outdated
Comment on lines
878
to
883
| Events: events, | ||
| TxResults: txResults, | ||
| ValidatorUpdates: endBlock.ValidatorUpdates, | ||
| ConsensusParamUpdates: &cp, | ||
| // If `NextBlockDelay` is 0, cometbft uses the legacy config `TimeoutCommit` instead. | ||
| NextBlockDelay: app.GetNextBlockDelay(app.finalizeBlockState.Context()), | ||
| }, nil |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/abci.go:733)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:894)
|
SimApp build is broken, I think you need to update it's dependencies on comet as well in the go.mod. |
vincentwschau
previously approved these changes
Nov 26, 2024
Comment on lines
878
to
884
| TxResults: txResults, | ||
| ValidatorUpdates: endBlock.ValidatorUpdates, | ||
| ConsensusParamUpdates: &cp, | ||
| // If `NextBlockDelay` is 0, cometbft uses the legacy config `TimeoutCommit` instead. | ||
| NextBlockDelay: app.GetNextBlockDelay(app.finalizeBlockState.Context()), | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/abci.go:733)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:894)
teddyding
force-pushed
the
td/next-block-delay
branch
from
356a31b to
5047a21
Compare
vincentwschau
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay
next_block_delayfrom application to CometBFT. Relayingnext_block_delay= 0 means CometBFT will default to usingtimeout_commit.