[CORE-852] Re-apply dYdX changes from 0.50.1 on top of 0.50.3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix lint/gocritic error * Disable some workflow jobs
This change pushes the mutex that was in the local client to the top level of the ABCI methods and uses the unsynchronized local client. A future change is intended to reduce the critical sections of the various ABCI methods. We also replace cometbft usage with dYdX fork.
This change makes a copy of `runTx` and does the following: * moves transaction descoding and tx validation before lock acquisition * moves creation of the response after releasing the lock * removes support for the post handler (unused by dYdX) and extracts out the only code that is executed in `runMsgs` allowing us to avoid the creation of the `runMsgCtx` and its associated `MultiStore` * removes `consumeBlockGas` since it is only executed during `deliverTx`
ctx.Done() support was added in 0.50 with cosmos#15041 server start up time was removed in 0.50 with cosmos#15041
|
@lcwik your pull request is missing a changelog! |
lcwik
changed the title
teddyding
reviewed
Jan 22, 2024
| @@ -172,7 +172,7 @@ is performed. Note, when enabled, gRPC will also be automatically enabled. | |||
| } | |||
|
|
|||
| err = wrapCPUProfile(serverCtx, func() error { | |||
| return start(serverCtx, clientCtx, appCreator, withCMT, opts) | |||
| return start(cmd.Context(), serverCtx, clientCtx, appCreator, withCMT, opts) | |||
There was a problem hiding this comment.
For my understanding why was this needed (asking because I don't see this change in https://github.com/dydxprotocol/cosmos-sdk/pull/30/files)
There was a problem hiding this comment.
It is to allow the caller to shutdown cosmos using the context that is associated with the command.
It was added later in b48250d
teddyding
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-apply dYdX changes from 0.50.1 on top of 0.50.3
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change