Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/class wrapper #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Chore/class wrapper #137

wants to merge 3 commits into from

Conversation

MarikaBBB
Copy link

@MarikaBBB MarikaBBB commented Jan 27, 2025

This PR is a follow up to the issue #32 and ensure that govuk-main-wrapper remains intact and functional. I made sure that the govuk-main-wrapper--l , mixin are not in used and has been removed before taking over this issue.

I believe no father action is required.

@RobjS
Copy link
Contributor

RobjS commented Jan 27, 2025

Hey @MarikaBBB, I think potentially there is some confusion here on the difference between a mixin and a standard CSS class.

A mixin is a set of styles defined in SASS that you can then re-use without having to re-write all the CSS every time: https://sass-lang.com/documentation/at-rules/mixin/.

It's the govuk-main-wrapper mixin that has been removed from the govuk-frontend. The .govuk-main-wrapper class is still supported, and expected to be part of the HTML template. As far as I can see, we're not using the mixin, so it may be that there isn't actually any work to address this issue. But I might be missing something!

@MarikaBBB
Copy link
Author

Thank you @RobjS . In this case my PR is just to review the issue, and verify that the govuk-main-wrapper class is still supported and functional. In this case, I will delete the code I wrote and change the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants