Refactor/use x debug headers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is conventional to use "X-" as a prefix for non- standard HTTP headers, and this is quite common in WordPress applications, including cache handling applications. The use of X- as a prefix is generally not recommended for new protocols, for reasons outlined here: https://datatracker.ietf.org/doc/html/rfc6648 However, in this case we are not expecting the debug headers in this plugin to become a widely adopted convention, and using X- seems like the least surprising naming to use.
snim2
force-pushed
the
refactor/use-x-debug-headers
branch
from
2bd25ed to
b65486c
Compare
RobjS
approved these changes
Feb 6, 2025
|
@RobjS I just realised I should have noted a breaking change int he ChangeLog... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is conventional to use
X-as a prefix for non-standard HTTP headers, and this is quite common in WordPress applications, including cache handling applications.The use of
X-as a prefix is generally not recommended for new protocols, for reasons outlined here:https://datatracker.ietf.org/doc/html/rfc6648
However, in this case we are not expecting the debug headers in this plugin to become a widely adopted convention, and using
X-seems like the least surprising naming to use.