create an insert function that is not a macro to compare to macro alt… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 59.09% 51.85% -7.24%
==========================================
Files 8 9 +1
Lines 22 27 +5
==========================================
+ Hits 13 14 +1
- Misses 9 13 +4
Continue to review full report at Codecov.
|
nelsonic
reviewed
Apr 26, 2019
| # alog doesn't have entry_id as a required_field, it just ensures that an | ||
| # entry_id is added to the changeset. | ||
| # see https://github.com/dwyl/alog/blob/master/lib/alog.ex#L112 | ||
| # :entry_id |
There was a problem hiding this comment.
we need make a couple of data transformation tables for this example to explain what the primary key of each record is so that:
a) each revision of the address record is unique
b) the address for a given person can be looked up by ID and we can see the history of the record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nelsonic following our convo I created an insert function that is not a macro to compare to macro alternative