[PR] Setting up Postgres and adding upload to S3
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuchoTurtle
added
documentation
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 54 76 +22
=========================================
+ Hits 54 76 +22 ☔ View full report in Codecov by Sentry. |
|
This is essentially done. I just need to add some tests to get coverage back to 100%. |
|
This should be mergeable 👌 |
LuchoTurtle
added
awaiting-review
nelsonic
added
in-review
nelsonic
added
merge-conflicts
# Conflicts: # mix.exs # mix.lock
nelsonic
added
in-review
nelsonic
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
This PR sets up a DB with Postgres with a simple
Imagetable with information regarding an image and makes use of https://github.com/dwyl/imgup to get the URL of the uploaded image so they're saved in anS3bucket.