Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding crossword words #130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jmonty42
Copy link
Contributor

This adds about 113k words to words_alpha.txt from the CROSSWD.TXT and CRSWD-D.TXT files from Moby Words II, which is referenced somewhere in this project. I found a couple oddly common words missing from words_alpha.txt and submitted PR's to add ones I noticed, so I decided to pull in those lists to get something more complete.

After combining the lists, I scanned through it manually with vimdiff to get an idea of what got added. Feel free to do the same and let me know if this is ok.

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Apr 21, 2022
@nelsonic nelsonic self-assigned this Apr 21, 2022
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to need a better way of viewing these extra large Diffs ... https://github.com/dwyl/english-words/pull/130/files

english-words-diff-too-large

@jmonty42
Copy link
Contributor Author

Ya, if you're familiar with vim, you can use vimdiff after you check out the branch locally to review it, that's what I did before I pushed it. There are lots of other diff clients you could use once you pull it down, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants