Add loading state to linked events #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperboone
requested review from
ARBaart,
ilgazer,
laurensWe,
sharwinbobde and
thomcsmits
laurensWe
approved these changes
Jan 15, 2025
thomcsmits
reviewed
Jan 15, 2025
| @@ -47,22 +47,38 @@ onMounted(() => { | |||
|
|
|||
| <template> | |||
| <section | |||
| v-if="events && events.length > 0" | |||
| v-if="events === null || events.length > 0" | |||
There was a problem hiding this comment.
dit moet events !== null zijn lijkt me?
There was a problem hiding this comment.
Als events gelijk is aan null, dan is er nog niks geset, dus zijn we nog aan het loaden.
Als events een lege array is hebben we wel wat geset, en dan zijn we klaar met loaden.
Vandaar dat we ook de case willen dat het null is en onderstaand dus tonen in alle gevallen behalve events.length === 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
load_before.mov
After:
load_after.mov
A bit less jarring