Skip to content

Commit

Permalink
Merge pull request #1214 from dvsa/fix/no-signing
Browse files Browse the repository at this point in the history
fix:comment out signing
  • Loading branch information
sr4850 authored Feb 25, 2025
2 parents 200092b + f619672 commit 4576258
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
30 changes: 15 additions & 15 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,18 +111,18 @@ jobs:
cache-to: type=gha,mode=max


- name: Setup Notation CLI
if: ${{ inputs.push }}
uses: notaryproject/notation-action/setup@v1
with:
version: "1.1.0"

- name: Sign artefact
if: ${{ inputs.push }}
uses: notaryproject/notation-action/sign@v1
with:
plugin_name: com.amazonaws.signer.notation.plugin
plugin_url: https://d2hvyiie56hcat.cloudfront.net/linux/arm64/plugin/latest/notation-aws-signer-plugin.zip
plugin_checksum: 423fb5f468518edde1c881d50714505dfdf05909bf83bbfddf2d32132caa68cd
key_id: arn:aws:signer:eu-west-1:054614622558:/signing-profiles/vol_qa20240522124422657400000001
target_artifact_reference: ${{ env.REGISTRY }}/vol-qa/vft@${{ steps.build-and-push.outputs.digest }}
# - name: Setup Notation CLI
# if: ${{ inputs.push }}
# uses: notaryproject/notation-action/setup@v1
# with:
# version: "1.1.0"
#
# - name: Sign artefact
# if: ${{ inputs.push }}
# uses: notaryproject/notation-action/sign@v1
# with:
# plugin_name: com.amazonaws.signer.notation.plugin
# plugin_url: https://d2hvyiie56hcat.cloudfront.net/linux/arm64/plugin/latest/notation-aws-signer-plugin.zip
# plugin_checksum: 423fb5f468518edde1c881d50714505dfdf05909bf83bbfddf2d32132caa68cd
# key_id: arn:aws:signer:eu-west-1:054614622558:/signing-profiles/vol_qa20240522124422657400000001
# target_artifact_reference: ${{ env.REGISTRY }}/vol-qa/vft@${{ steps.build-and-push.outputs.digest }}
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<maven.compiler.version>3.13.0</maven.compiler.version>

<active-support.version>2.5.14</active-support.version>
<api-calls.version>3.0.1</api-calls.version>
<api-calls.version>3.0.2</api-calls.version>
<uri-constructor.version>2.1.0</uri-constructor.version>

<axe-scanner-version>2.11.0</axe-scanner-version>
Expand Down

0 comments on commit 4576258

Please sign in to comment.