Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Styling for Character Build Pages #73

Closed
wants to merge 15 commits into from
Closed

Fixed Styling for Character Build Pages #73

wants to merge 15 commits into from

Conversation

riceconfetti
Copy link
Contributor

No description provided.

@riceconfetti riceconfetti requested a review from a team as a code owner March 29, 2024 14:43
LudovicMalot
LudovicMalot previously approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@LudovicMalot LudovicMalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good.
Lots of comment, they will have to be raised as an issue or fixed before this merge or else we might forgot.
For all data needs, same thing feel free to just spam issues :), you can even put a hight priority tag so we fix it ASAP

@riceconfetti
Copy link
Contributor Author

updated with the gacha_cards in place of the splash art, the grid keeps resizing slightly when opening the talent accordions but i didn't see it causing any overlap issues. will try to fix that tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudovicMalot LudovicMalot LudovicMalot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riceconfetti @LudovicMalot