Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate build step from workflow and cache dependencies #597

Merged
merged 10 commits into from
Nov 18, 2024
Merged

feat: separate build step from workflow and cache dependencies #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
121bb57
feat: separate build step from workflow and cache dependencies
maalni Nov 18, 2024
9406098
fix: add cache option to setup-node
maalni Nov 18, 2024
2a00b2f
fix: install pnpm before node
maalni Nov 18, 2024
bfe27a2
fix: install pnpm before node for all tasks
maalni Nov 18, 2024
24e5e94
fix: remove caching of pnpm dependencies
maalni Nov 18, 2024
934802c
fix: adjust caching directory
maalni Nov 18, 2024
e94f1da
chore: update github-actions-cloudflare-pages to v2
maalni Nov 18, 2024
e424a47
chore: update github-actions-cloudflare-pages to v2.4.1
maalni Nov 18, 2024
a6000fa
fix: remove typo
maalni Nov 18, 2024
307e0fd
chore: remove unnecessary install dependencies step
maalni Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 59 additions & 21 deletions .github/workflows/check-code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,32 +15,58 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: lts/Iron
- uses: pnpm/action-setup@v3
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 9
run_install: true
run_install: false
- uses: actions/setup-node@v4
with:
node-version: lts/Iron
- name: Install dependencies
run: pnpm install
- name: Check TypeScript
run: pnpm tsc
check-prettier:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 9
run_install: false
- uses: actions/setup-node@v4
with:
node-version: lts/Iron
- uses: pnpm/action-setup@v3
- name: Install dependencies
run: pnpm install
- name: Check Prettier & Eslint
run: pnpm run lint
build:
needs: [check-typescript, check-prettier]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 9
run_install: true
- name: Check Prettier & Eslint
run: pnpm run lint
run_install: false
- uses: actions/setup-node@v4
with:
node-version: lts/Iron
- name: Install dependencies
run: pnpm install
- name: Build
run: pnpm run build
- name: Save build cache
uses: actions/cache/save@v4
with:
key: website-build
path: ./build
deploy-to-cloudflare:
needs: [check-typescript, check-prettier]
needs: [build]
if: ${{ github.event_name != 'pull_request' || github.actor != 'dependabot[bot]' }}
environment: ${{ vars.CLOUDFLARE_PROJECT_NAME }} ${{ (github.ref == 'refs/heads/main' && '(Production)') || '(Preview)' }}
env:
Expand All @@ -52,21 +78,24 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: lts/Iron
- uses: pnpm/action-setup@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 9
run_install: true
- name: Build
run: pnpm run build
run_install: false
- uses: actions/setup-node@v4
with:
node-version: lts/Iron
- name: Install dependencies
run: pnpm install
- name: Retrieve build cache
uses: actions/cache/restore@v4
with:
key: website-build
path: ./build
- name: Publish to Cloudflare Pages
uses: unlike-ltd/github-actions-cloudflare-pages@fb5958dd486c5c2cb38b3a843e1efb160878060d #v1.3.2
uses: andykenward/github-actions-cloudflare-pages@v2.4.1
id: pages
with:
cloudflare-api-token: ${{ secrets.CLOUDFLARE_API_TOKEN }}
Expand All @@ -75,4 +104,13 @@ jobs:
directory: 'build'
github-token: ${{ secrets.GITHUB_TOKEN }}
github-environment: ${{ vars.CLOUDFLARE_PROJECT_NAME }} ${{ (github.ref == 'refs/heads/main' && '(Production)') || '(Preview)' }}
- name: 'Delete old deployments'
uses: andykenward/github-actions-cloudflare-pages/[email protected]
with:
keep-latest: 5
cloudflare-api-token: ${{ secrets.CLOUDFLARE_API_TOKEN }}
cloudflare-account-id: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
cloudflare-project-name: ${{ vars.CLOUDFLARE_PROJECT_NAME }}
github-token: ${{ secrets.GITHUB_TOKEN }}
github-environment: ${{ vars.CLOUDFLARE_PROJECT_NAME }} ${{ (github.event.pull_request.head.ref == 'refs/heads/main' && '(Production)') || '(Preview)' }}

6 changes: 2 additions & 4 deletions .github/workflows/delete-redundant-deployments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ on:
pull_request:
types:
- closed
branches:
- main

jobs:
delete:
Expand All @@ -18,11 +16,11 @@ jobs:
timeout-minutes: 5
steps:
- name: 'Delete Cloudflare Pages deployments'
uses: unlike-ltd/github-actions-cloudflare-pages@fb5958dd486c5c2cb38b3a843e1efb160878060d #v1.3.2
uses: andykenward/github-actions-cloudflare-pages/[email protected]
with:
keep-latest: 5
cloudflare-api-token: ${{ secrets.CLOUDFLARE_API_TOKEN }}
cloudflare-account-id: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
cloudflare-project-name: ${{ vars.CLOUDFLARE_PROJECT_NAME }}
directory: 'build'
github-token: ${{ secrets.GITHUB_TOKEN }}
github-environment: ${{ vars.CLOUDFLARE_PROJECT_NAME }} ${{ (github.event.pull_request.head.ref == 'refs/heads/main' && '(Production)') || '(Preview)' }}
Loading