Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: add support for persistent state builds with docker #3402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docker: add support for persistent state builds with docker #3402

wants to merge 1 commit into from
+293 −2

Conversation

d-sonuga
Copy link
Collaborator

For #1080

@d-sonuga d-sonuga force-pushed the persistent-docker-build branch from f99ee4c to 37894ed Compare January 21, 2025 21:32
@d-sonuga d-sonuga requested a review from Daksh14 January 21, 2025 21:32
@d-sonuga d-sonuga force-pushed the persistent-docker-build branch from 37894ed to 540b9a5 Compare January 23, 2025 16:09
@d-sonuga d-sonuga requested a review from lufa23 January 23, 2025 16:10
@d-sonuga d-sonuga force-pushed the persistent-docker-build branch from 540b9a5 to 2f1a7cf Compare January 23, 2025 16:22
@d-sonuga d-sonuga marked this pull request as ready for review January 27, 2025 19:02
Daksh14
Daksh14 requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@Daksh14 Daksh14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the docker file yet, good work so far I got couple of RFC(s) will run the docker file and let you know

Dockerfile.persistent Show resolved Hide resolved
scripts/persistent-docker-setup/conf/rusk.toml Outdated Show resolved Hide resolved
scripts/persistent-docker-setup/detect_ips.sh Show resolved Hide resolved
scripts/persistent-docker-setup/setup.sh Show resolved Hide resolved
README.md Show resolved Hide resolved
@Daksh14 Daksh14 requested a review from HDauven January 27, 2025 21:26
@d-sonuga d-sonuga force-pushed the persistent-docker-build branch 7 times, most recently from 5f4ba88 to 7db8d75 Compare January 31, 2025 18:50
@d-sonuga d-sonuga requested a review from Daksh14 January 31, 2025 18:54
@d-sonuga d-sonuga force-pushed the persistent-docker-build branch 2 times, most recently from 5fd7550 to 5905df0 Compare February 1, 2025 10:49
@d-sonuga d-sonuga force-pushed the persistent-docker-build branch from 5905df0 to 9e75bb3 Compare February 4, 2025 16:29
Daksh14
Daksh14 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Daksh14 Daksh14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing port forwarding didnt work for me, but @d-sonuga mentioned it does work for him so must be wrong my side

other than that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daksh14 Daksh14 Daksh14 approved these changes

@lufa23 lufa23 Awaiting requested review from lufa23

@HDauven HDauven Awaiting requested review from HDauven

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

@pmoranga pmoranga Awaiting requested review from pmoranga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-sonuga @Daksh14