Fix non-interactive sessions when using groups option (Issue #206) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number being addressed
Fixes #206
Summary of the change
Detect and set the headless variable earlier in do_auth() so that motd is not printed in non-interactive sessions.
Test Plan
Create a login_duo.conf file using the groups option and motd=yes. Log in as a user not in the specified group, both in an interactive session (i.e. ssh) and non-interactive (i.e. sftp). In the interactive session, motd should be printed. In the non-interactive session, nothing is printed, so the session is not broken by unexpected output.