-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for v5 signatures #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpd-duo
reviewed
Aug 25, 2023
yizshi
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the canonicalization part looks right to me
mbish
requested changes
Sep 7, 2023
mbish
reviewed
Sep 7, 2023
mbish
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new function
JSONSignedCall()
. Calls made through this function will use a v5 signature automatically.Motivation and Context
V5 signatures and params encoded as JSON are required for the new policy API endpoints (see https://duo.com/docs/adminapi#policies). However, updating the existing SignedCall function would break existing golang client users. By adding a separate call, we can add support for future policy calls without disrupting existing code.
How Has This Been Tested?
Added new tests for the internal functions. Also verified the new call works with GETs and POSTs, both with and without params.
Example of how to use the new function:
Types of Changes