authentication: return user verified flag #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Some other libs like webauthn-rs enforce that when user verification is only preferred and that a device previously performed user verification, it must continue to perform it on later authentication, as it proved that it was user verification capable. Whether this out-of-spec check is desirable is an open question, however if someone wants to align behavior between a webauthn-rs-based implem and a py_webauthn implem then returning this information is necessary.
ggirol-rc
force-pushed
the
return_uv_flag
branch
from
42d82fa to
4aafae1
Compare
|
Hey @ggirol-rc thanks for the suggestion. This looks fine with me, though what do you think about adding this to |
|
Hi, I think it is already present for registration |
|
Oh, you're right, my bad. It's been a while since I've looked at that particular method 🤦♂️ Alright then, I'm going to kick off tests and assuming those pass I'll merge. This'll go out as part of a v2.4.1 update I'm planning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other libs like webauthn-rs enforce that when user verification is only preferred and that a device previously performed user verification, it must continue to perform it on later authentication, as it proved that it was user verification capable. Whether this out-of-spec check is desirable is an open question, however if someone wants to align behavior between a webauthn-rs-based implem and a py_webauthn implem then returning this information is necessary.