Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Logger from Caddy context #1369

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

IndraGunawan
Copy link
Contributor

@IndraGunawan IndraGunawan commented Feb 13, 2025

since FrankenPHPApp module has implemented caddy.Provisioner
using logger from Caddy context gives us clear information if the logs written by FrankenPHPApp module

Before

2025/02/13 08:00:11.443 INFO    FrankenPHP started 🐘   {"php_version": "8.4.5-dev", "num_threads": 20}
2025/02/13 08:02:11.983 INFO    FrankenPHP stopped 🐘

After

2025/02/13 08:03:25.195 INFO    frankenphp      FrankenPHP started 🐘   {"php_version": "8.4.5-dev", "num_threads": 20}
2025/02/13 08:03:51.717 INFO    frankenphp      FrankenPHP stopped 🐘

@dunglas dunglas merged commit 1c097a6 into dunglas:main Feb 17, 2025
34 of 40 checks passed
@dunglas
Copy link
Owner

dunglas commented Feb 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants