Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs for first-time contributor #1368

Merged
merged 1 commit into from
Feb 17, 2025
Merged

update docs for first-time contributor #1368

merged 1 commit into from
Feb 17, 2025

Conversation

IndraGunawan
Copy link
Contributor

updating contibuting.md to make things work on the first try

@IndraGunawan IndraGunawan force-pushed the update-contributing-docs branch from d0e51a0 to 21e185e Compare February 12, 2025 12:04
IndraGunawan
IndraGunawan commented Feb 12, 2025
View reviewed changes
dev.Dockerfile
cmake --install build
cmake --install build && \
cp build/libwatcher-c.so /usr/local/lib/libwatcher-c.so && \
ldconfig
Copy link
Contributor Author

@IndraGunawan IndraGunawan Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following this comment #1156 (comment)

@dunglas
Copy link
Owner

dunglas commented Feb 12, 2025

Good catches!

@dunglas dunglas merged commit 233753c into dunglas:main Feb 17, 2025
35 of 40 checks passed
@dunglas
Copy link
Owner

dunglas commented Feb 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@withinboredom withinboredom withinboredom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IndraGunawan @dunglas @withinboredom