fix missing metrics #1366
Merged
fix missing metrics #1366
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndraGunawan
force-pushed
the
fix-missing-metrics
branch
from
bcc320c to
7306d42
Compare
|
Nice catch, but in the future can you fill in the PR description with what your PR does? This way we don't have to go spelunking through issues and other project PRs to figure out what you are trying to accomplish. It only takes you a few minutes, but saves everyone reviewing a ton of time. |
|
The Mercure module likely needs the same refactoring btw. |
dunglas
approved these changes
Feb 12, 2025
|
@dunglas this looks good to merge, but the tests have a weird failure. Is this normal? If so, and @IndraGunawan is ready, lets merge it. |
|
All failures are known random network/rate limit issues or flaky tests. It's "normal". |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1365
update Caddy metrics registry
as of Caddy v2.9 (caddyserver/caddy@41f5dd5) it changed the flow to get the metrics registry