Skip to content

Commit

Permalink
remove waiting gif in reactor
Browse files Browse the repository at this point in the history
I think the new style gives HTML with JS inline. That means the compile
will be done by the time the browser gets the HTML, so the waiting
animation wouldn't show.

Would need to structure it differently to show a waiting animation, but
hopefully with the incremental compiles, this wouldn't really make
sense to have.

Maybe it makes sense to log package downloads on the terminal though.
That seems like something that'd make a slower build.
  • Loading branch information
evancz committed Jun 18, 2019
1 parent 5ecb070 commit 0068bc1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
Binary file removed reactor/assets/waiting.gif
Binary file not shown.
6 changes: 0 additions & 6 deletions terminal/src/Develop/StaticFiles.hs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ dict :: HM.HashMap FilePath (BS.ByteString, MimeType)
dict =
HM.fromList
[ faviconPath ==> (favicon , "image/x-icon")
, waitingPath ==> (waiting , "image/gif")
, elmPath ==> (elm , "application/javascript")
, cssPath ==> (css , "text/css")
, codeFontPath ==> (codeFont, "font/ttf")
Expand Down Expand Up @@ -122,8 +121,3 @@ sansFont =
favicon :: BS.ByteString
favicon =
$(bsToExp =<< runIO (Build.readAsset "favicon.ico"))


waiting :: BS.ByteString
waiting =
$(bsToExp =<< runIO (Build.readAsset "waiting.gif"))

0 comments on commit 0068bc1

Please sign in to comment.