Skip to content
This repository has been archived by the owner on Feb 24, 2025. It is now read-only.

Always open Watch In Youtube links in a new tab #3740

Closed
wants to merge 1 commit into from

Conversation

afterxleep
Copy link
Contributor

@afterxleep afterxleep commented Jan 15, 2025

Task/Issue URL: https://app.asana.com/0/1204099484721401/1207942134403719/f
Tech Design URL:
CC:

Description:
Always Open “Watch in Youtube” links in a new tab. This fixes a lot of back-forward navigation with DuckPlayer in the same tab, incluiding the task above

Steps to test this PR:

  • 1. Go to Settings > DuckPlayer
  • 2. Disable “Open Duck Player in a new tab, whenever possible”
  • 3. Enable “Always open Youtube videos in Duck Player"
  • 4. Go to https://www.youtube.com/@mkbhd
  • 5. Open a Video, which should open in Duck Player and make sure it’s playing
  • 6. Click “Watch in Youtube” button at the bottom.
  • 7. Confirm the video opens in a new tab, and the previous video pauses.
  • 8. Hit the back button, and confirm the newly opened tab is closed and you’re back to the paused video.

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jan 23, 2025
Copy link
Contributor

This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions.

@github-actions github-actions bot closed this Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant