-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets for Duck.ai #3854
Widgets for Duck.ai #3854
Conversation
# Conflicts: # Core/PixelEvent.swift
|
@@ -119,6 +118,23 @@ struct PasswordsLockScreenWidget: Widget { | |||
} | |||
} | |||
|
|||
/// Waiting copywriting and icon for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to leave it here, you can already test it by adding the AIChatLockScreenWidget into the Widgets.swift
@@ -443,7 +443,8 @@ struct Foreground: AppState { | |||
DispatchQueue.main.asyncAfter(deadline: DispatchTime.now() + 0.5) { | |||
mainViewController.launchAutofillLogins(openSearch: true, source: source) | |||
} | |||
|
|||
case .openAIChat: | |||
AIChatDeepLinkHandler().handleDeepLink(url, on: mainViewController) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this as a blocker, but I noticed that this will recreate the AI Chat view when the view is already open, so the history gets wiped out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have saved chats. This is by design because every time you open duck.ai, it should start with a clean slate (it used to save the state, but a change was requested). That said, the previous conversation is stored in the history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall no issues from my side, just left a couple comments related to typos and one note about the deep link logic executing even when Duck.ai is already visible, but none of these are blockers. The widgets work really nicely - great work!
Co-authored-by: Sam Symons <[email protected]>
Co-authored-by: Sam Symons <[email protected]>
Task/Issue URL: https://app.asana.com/0/72649045549333/1209001137946571/f
Description:
Add support for Duck.ai widgets
Changes:
Steps to test this PR:
!Make sure to set yourself as internal first!
Favorites
——
Quick Actions
——
Control Center
Definition of Done (Internal Only):
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template