Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malicious site protection detection integration #3844

Open
wants to merge 10 commits into
base: alessandro/malicious-site-protection-datasets-fetcher
Choose a base branch
from

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208758247571054/f
CC: @not-a-rootkit

Description:

Integrate BSK library for malicious threat detection.

Steps to test this PR:

Prerequisites: Return true in MaliciousSiteProtectionFeatureFlags.swift -> isMaliciousSiteProtectionEnabled and shouldDetectMaliciousThreat(forDomain domain: String?) -> Bool

Scenario 1 - Phishing

  1. Navigate to http://privacy-test-pages.site/security/badware/phishing.html
  2. Ensure special error pages is shown.

Scenario 2 - Malware

  1. Navigate to http://privacy-test-pages.site/security/badware/malware.html
  2. Ensure special error pages is shown.

Scenario 3 - Leave Site Creates an Empty Tab at same index of the tab closed

  1. Open multiple tabs and load some random websites
  2. Open a tab and load a malicious website.
  3. When the special error page is shown, tap the “Leave Site” Button.
  4. Ensure that when the Tab is closed a new empty one is created at the same index.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@alessandroboron alessandroboron changed the base branch from alessandro/malicious-site-protection to alessandro/malicious-site-protection-datasets-fetcher January 22, 2025 00:25
@alessandroboron alessandroboron changed the title Alessandro/malicious site protection detection integration Malicious site protection detection integration Jan 22, 2025
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-detection-integration branch from 6076c20 to 7f0d242 Compare January 22, 2025 06:34
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-datasets-fetcher branch from 1620417 to 0e328f1 Compare January 23, 2025 00:52
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-detection-integration branch from 7f0d242 to f498258 Compare January 23, 2025 01:00
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-datasets-fetcher branch from 0e328f1 to f5153e0 Compare January 24, 2025 08:20
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-detection-integration branch from f498258 to bdb5bf4 Compare January 24, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant