-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malicious Site Protection - Pixels #3779
base: alessandro/malicious-site-protection-settings
Are you sure you want to change the base?
Malicious Site Protection - Pixels #3779
Conversation
fae19a7
to
5be55a9
Compare
cc1da21
to
6aeb628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pixels are fired as expected!
func leaveSite() { | ||
// Fire Pixel | ||
} | ||
func leaveSite() { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking: No pixel and not implemented yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t fire any pixels when the user taps “Leave site” button. Implementation is in its parent which is generic special error handler. It calls leaveSite on its children in case we need to do custom actions. But it’s not the case as we’re not sending pixels.
func advancedInfoPresented() { | ||
// Fire Pixel | ||
} | ||
func advancedInfoPresented() { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking: No pixel to send?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Above
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
0d2df3b
to
1a42e54
Compare
3a690aa
to
81f4f71
Compare
1537387
to
d2d7bd4
Compare
81f4f71
to
b20b0a3
Compare
d2d7bd4
to
560ed08
Compare
5323ec5
to
1f2627c
Compare
Task/Issue URL: https://app.asana.com/0/1206329551987282/1207169456840072/f
Description:
This PR adds the pixel events for the malicious site protection feature.
Pixels definition
Note that iframes handling is descoped for the time being.
Steps to test this PR:
Prerequisites
Ensure that
isMaliciousSiteProtectionEnabled
andshouldDetectMaliciousThreat(forDomain domain: String?) -> Bool
defined inMaliciousSiteProtectionFeatureFlags.swift
-> returntrue
Scenario 1 - Navigate to a Malicious site - Phishing
malicious-site-protection_error-page-shown
is fired with categoryphishing
.Scenario 2 - Navigate to a Malicious site - Malware
malicious-site-protection_error-page-shown
is fired with categorymalware
.Scenario 3 - Visit Malicious Site - Phishing
malicious-site-protection_visit-site
is fired with categoryphishing
.Scenario 4 - Visit Malicious Site - Malware
malicious-site-protection_visit-site
is fired with categorymalware
.Scenario 3 - Enable/Disable feature in App settings
malicious-site-protection_feature-toggled
is fired with parameternewState
true / false depending on the setting value.Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template