Skip to content

Commit

Permalink
Revert recent change to clean target in Makefile (#1832)
Browse files Browse the repository at this point in the history
There was a bug in the Makefile, whereby `make clean` would run
`rm -rf $(BUILD_DIR)` which usually resulted in `rm -rf build//` being
run. By happenstance this worked, clearing the build directory. I
fixed that, by changing the script to run `rm -rf build` directly.

However, it turns out that the release target also runs `make clean`,
but with the BUILD_DIR variable set correctly. It expected only the
targetted build to be cleared, so when the whole build directory was
cleared instead the release process failed.

For now, let's revert that change, to unblock today's release. In the
future, we should handle this properly.
  • Loading branch information
kzar authored Mar 28, 2023
1 parent 712bc8f commit 0393d40
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ npm:
## clean: Clear the builds and temporary files.
clean:
rm -f shared/data/smarter_encryption.txt shared/data/bundled/smarter-encryption-rules.json integration-test/artifacts/attribution.json:
rm -rf build
rm -rf $(BUILD_DIR)

.PHONY: clean

Expand Down

0 comments on commit 0393d40

Please sign in to comment.