Reduce filter list size by using domain popularity, updating encoding, and removing unapplicable rules #587
+994
−9,023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muodov
added
minor
muodov
reviewed
Jan 10, 2025
| @@ -81,6 +81,7 @@ | |||
| "dependencies": { | |||
| "@ghostery/adblocker": "^2.0.4", | |||
| "@ghostery/adblocker-content": "^2.0.4", | |||
| "csv-parse": "^5.6.0", | |||
There was a problem hiding this comment.
Let's move this to devDependencies?
Comment on lines
+37
to
+42
| !line.startsWith('!') && | ||
| !line.startsWith('##') && | ||
| !line.startsWith('||') && | ||
| !line.includes(':remove') && | ||
| !line.includes(':upward') && | ||
| !line.includes('redirect-rule'), |
There was a problem hiding this comment.
Could you add some comments on what each of these prefixes mean and why we're filtering them out?
| */ | ||
| async function rebuildFilterList() { | ||
| await loadTrancoList(); | ||
| await processFilterList('easylist_cookie_specific_uBO.txt'); |
There was a problem hiding this comment.
should we call processFilterlist() on all input files, not just "specific" ones?
Comment on lines
+45
to
+46
| for (const line in filteredLines) { | ||
| const rule = filteredLines[line]; |
There was a problem hiding this comment.
Suggested change
| for (const line in filteredLines) { | |
| const rule = filteredLines[line]; | |
| for (const rule of filteredLines) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes substantial changes to
rebuild-filterlist.mjsandcompile-filterlist.mjsin an effort to reduce the size of the filter list and ultimately the injected bundle with minimal impact to coverage.Notable changes:
Through these change we're able to reduce the resulting
filterlist-engine.tsby over 60% (4.2M -> 1.8M), which should help significantly with performance.