Handle 404 from /api/subscription #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlenDimla
approved these changes
Jan 23, 2025
lmac012
deleted the
feature/lukasz/handle-404-on-fetching-subscription
branch
anikiki
pushed a commit
that referenced
this pull request
Jan 23, 2025
Task/Issue URL: https://app.asana.com/0/1205648422731273/1209217826294375/f ### Description /api/subscription endpoint currently returns 400 when no subscription is found, but that will change to 404. We should handle both 400 and 404 for now. ### Steps to test this PR QA-optional ### No UI changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205648422731273/1209217826294375/f
Description
/api/subscription endpoint currently returns 400 when no subscription is found, but that will change to 404. We should handle both 400 and 404 for now.
Steps to test this PR
QA-optional
No UI changes