Merge pull request #2 from carlopi/wasm_c_capi

Add support for Wasm targets
duckdb · Nov 18, 2024 · 61e7420 · 61e7420
2 parents 6764e09 + a6f1499
commit 61e7420
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/MainDistributionPipeline.yml b/.github/workflows/MainDistributionPipeline.yml
@@ -20,4 +20,3 @@ jobs:
       ci_tools_version: main
       extension_name: capi_quack
       extra_toolchains: python3
-      exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,5 @@
 cmake_minimum_required(VERSION 2.8)
+option(DUCKDB_WASM_EXTENSIONS "Whether compiling for Wasm target" OFF)
 
 ###
 # Configuration
@@ -26,7 +27,12 @@ set(EXTENSION_SOURCES
         src/add_numbers.c
         src/capi_quack.c
 )
-add_library(${EXTENSION_NAME} SHARED ${EXTENSION_SOURCES})
+
+if (DUCKDB_WASM_EXTENSION)
+	add_library(${EXTENSION_NAME} STATIC ${EXTENSION_SOURCES})
+else()
+	add_library(${EXTENSION_NAME} SHARED ${EXTENSION_SOURCES})
+endif()
 
 # Hide symbols
 set(CMAKE_CXX_VISIBILITY_PRESET hidden)

diff --git a/extension-ci-tools b/extension-ci-tools
+26 −0		.github/workflows/TestCITools.yml
+1 −1		README.md
+1 −1		makefiles/c_api_extensions/base.Makefile
+36 −9		makefiles/c_api_extensions/c_cpp.Makefile