support compress request body #403
Conversation
zuisong
force-pushed
the
compress-request-body
branch
from
d7f708a to
f85194a
Compare
src/main.rs
Outdated
| if args.compress >= 1 && request.headers().get(CONTENT_ENCODING).is_none() { | ||
| let mut compressed = false; | ||
| if let Some(body) = request.body_mut() { | ||
| if let Some(body_bytes) = body.as_bytes() { |
There was a problem hiding this comment.
Can we make this work for streaming requests as well (i.e. xh -x : @file.txt)? In that case it might be best to just compress unconditionally even with a single -x so that we don't have to buffer it.
(HTTPie does buffer the whole file in this case.)
There was a problem hiding this comment.
I think it's possible; the latest commit supports this. 😄
There was a problem hiding this comment.
Awesome, that gets us the same behavior as HTTPie. But we might want to diverge from HTTPie by streaming the body in this case instead of buffering it, so that it's possible to upload files that don't fit in RAM. That should be possible with ReqwestBody::new.
(I also suggested this in httpie/cli#1613 so we could wait to see what they think.)
There was a problem hiding this comment.
We can directly compress the stream without buffering it , which would make it different from httpie's implementation.
Should we do it this way in this PR?
[update] The into_reader() method of reqwest#Body is pub(crate). We cannot access it. Currently, it is not possible to achieve our goal.
zuisong
force-pushed
the
compress-request-body
branch
from
e64e14f to
1ec0267
Compare
implements https://httpie.io/docs/cli/compressed-request-body