Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line #1419

Closed
wants to merge 3 commits into from
Closed

Line #1419

wants to merge 3 commits into from

Conversation

oumz11
Copy link

@oumz11 oumz11 commented Dec 25, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2024

CLA assistant check
All committers have signed the CLA.

@calumcalder
Copy link
Collaborator

Hi @oumz11 - thanks for opening this PR. It looks like you're trying to set up automated publishing for this repo, which we happen to already be working on! (see #1420, #1421, #1423)

Your proposal seems to be based on Github's docs https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#publishing-using-gradle which doesn't quite map to our set-up; in particular, we publish to maven central and use conventional-commits to generate the changelog and version. You can see some more details in the linked PRs.
With that in mind, I'm going to close out this PR since the work for setting up automated publishing is mostly done in those other PRs. If there's a requirement to also publish to github's package repository, feel free to open an issue and we can look at setting that up.

@calumcalder calumcalder closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants