Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2705 main_v5.1 - SeriesAnalysis fix time substitution into field info #2707

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Sep 30, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

Confirmed use case described in discussion #2687 now substitutes the correct values into the field info for the 12 hour and 24 hour forecast lead runs. Previously the time info was the same for both.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure that all automated tests pass and no differences to any use case results from this change

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 9/30/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-5.1.1 Bugfix milestone Sep 30, 2024
@georgemccabe georgemccabe linked an issue Sep 30, 2024 that may be closed by this pull request
24 tasks
@georgemccabe georgemccabe marked this pull request as ready for review September 30, 2024 19:23
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this change. I see that only the series_analysis wrapper file is updated and that the timing data is now stored in the var_info object. I note that all the automated tests passed with no differences being flagged.

While I did not test the functionality directly myself, @georgemccabe and I met during which he demonstrated that the change works as expected. The expected timing information really does appear in the field level strings, such as level="(20240807_12,*,*)"; for NetCDF files.

@georgemccabe georgemccabe merged commit 5d075af into main_v5.1 Sep 30, 2024
72 checks passed
@georgemccabe georgemccabe deleted the bugfix_2705_main_v5.1_sa_time branch September 30, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Improve SeriesAnalysis field info generation with regards to time
2 participants