Skip to content

Commit

Permalink
Initialize functions earlier, fix doc (idaholab#29639)
Browse files Browse the repository at this point in the history
  • Loading branch information
dschwen committed Jan 4, 2025
1 parent 061e9c5 commit cfebccc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 13 deletions.
24 changes: 12 additions & 12 deletions framework/src/problems/FEProblemBase.C
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,18 @@ FEProblemBase::initialSetup()
_convergences.initialSetup(tid);
}

{
TIME_SECTION("initializingFunctions", 5, "Initializing Functions");

// Call the initialSetup methods for functions
for (THREAD_ID tid = 0; tid < n_threads; tid++)
{
reinitScalars(tid); // initialize scalars so they are properly sized for use as input into
// ParsedFunctions
_functions.initialSetup(tid);
}
}

// UserObject initialSetup
std::set<std::string> depend_objects_ic = _ics.getDependObjects();
std::set<std::string> depend_objects_aux = _aux->getDependObjects();
Expand Down Expand Up @@ -1027,18 +1039,6 @@ FEProblemBase::initialSetup()
if (_requires_nonlocal_coupling)
setVariableAllDoFMap(_uo_jacobian_moose_vars[0]);

{
TIME_SECTION("initializingFunctions", 5, "Initializing Functions");

// Call the initialSetup methods for functions
for (THREAD_ID tid = 0; tid < n_threads; tid++)
{
reinitScalars(tid); // initialize scalars so they are properly sized for use as input into
// ParsedFunctions
_functions.initialSetup(tid);
}
}

{
TIME_SECTION("initializingRandomObjects", 5, "Initializing Random Objects");

Expand Down
4 changes: 3 additions & 1 deletion framework/src/userobjects/SolutionUserObject.C
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ SolutionUserObject::validParams()
"Anticlockwise rotation angle (in degrees) to use for rotation about rotation1_vector.");

params.addParam<FunctionName>(
"time_transformation", "t", "Transfrom between simulation time and solution time.");
"time_transformation",
"t",
"Transform from current simulation time to time at which to sample the solution.");

// following lines build the default_transformation_order
MultiMooseEnum default_transformation_order(
Expand Down

0 comments on commit cfebccc

Please sign in to comment.