Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): remove configurable vault s3 bucket versioning #298

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

abby-ng
Copy link
Contributor

@abby-ng abby-ng commented Mar 6, 2024

Context:

  • the current vault s3 bucket versioning is configurable from the vault-cluster module but can not be passed in from the core parent module, thus not from the grandparent module, i.e. l-cloud-gcc core module. This makes it almost useless.
  • there is another logs s3 bucket in the fluentd module which comes with default versioning config, i.e. no versioning config (default to false).

Description:

  • this helper package should come with default config. Customized configuration can be done at the parent, i.e. l-cloud-gcc for maintainability so that all configs for the buckets are in 1 place
  • this sync with the logs s3 bucket in the fluentd module

@abby-ng abby-ng requested review from Tingweiftw and tyng94 March 6, 2024 05:08
@abby-ng abby-ng force-pushed the chore--enable-s3-versioning branch from ede9637 to 3a76bd0 Compare March 6, 2024 05:24
@abby-ng abby-ng force-pushed the chore--enable-s3-versioning branch from fd99734 to 37918a3 Compare March 6, 2024 05:27
@abby-ng abby-ng changed the title feat(vault): configurable vault s3 bucket versioning feat(vault): remove configurable vault s3 bucket versioning Mar 6, 2024
Copy link
Contributor

@tyng94 tyng94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abby-ng abby-ng merged commit 65d46f8 into master Mar 7, 2024
3 checks passed
@abby-ng abby-ng deleted the chore--enable-s3-versioning branch March 7, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants