-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds complex math expressions support #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sobolevn I'm not sure about typing, could you take a look please? |
sobolevn
reviewed
Jul 11, 2020
…able` class. Using the return type as `Callable[[_Number], _Number]` we got some mypy errors while composing complex math expressions!
thepabloaguilar
changed the title
[WIP] Adds complex math expressions support
Adds complex math expressions support
Jul 11, 2020
@sobolevn I've reached 97% of test coverage, because # FROM
class _Callable(object):
__and__: Callable[['_Callable', T1], Callable[[T1], T1]] = _fmap(operator.and_)
# TO
class _Callable(object):
def __and__(self, other: Any) -> Callable[['_Callable', T1], Callable[[T1], T1]]:
return _fmap(operator.and_) After the conversion we will have to write all the tests, I can write them after this PR! |
@sobolevn is something else needed? |
sobolevn
approved these changes
Jul 17, 2020
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the
_MathExpression
callable class to work with complex math expressions.It accumulate the operations when the instance is called all the operations are reduced to get the final result!
Example:
I've modified
_Callable
class too, to use the_MathExpression
in its math operation and now we can use it normally, no side effects:TODO:
closes #1