Bug when using lmt on code in "unknown" languages #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing a default case for languages without a small guard for empty strings in fmt.Println, a tiny bug was introduced which pasted lots of junk in our inputfiles. Some of it was not parseable perl. This commit tries to correct it, cleans up the code a wee bit and tries to make it easier to add more languages in the future.
|
Sorry, somehow I missed this and now it has conflicts since I just pushed a really quick fix for the unknown languages bug. If you want to rebase for your cleanup and other languages, I'll try not to miss it this time.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a default case for languages without a small guard for
empty strings in fmt.Println, a tiny bug was introduced which pasted
lots of junk in our inputfiles. Some of it was not parseable perl.
This commit tries to correct it, cleans up the code a wee bit and tries
to make it easier to add more languages in the future.